Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

season attributes other than seasonNumber should be optional in schema2.xsd #24

Open
vsagarv opened this issue Mar 28, 2023 · 0 comments
Assignees

Comments

@vsagarv
Copy link
Contributor

vsagarv commented Mar 28, 2023

While running pubrss-2-amgrss, the test input e67004c-0.xml fails validation with the following error:

failed validating <Element '{http://www.amagi.com/amgrss/}season' at 0x1083f14e0> with Xsd11Group(model='sequence', occurs=[1, 1]):

Reason: The content of element 'tns:season' is not complete. Tag 'tns:seasonTitle' expected.

schema2.xsd expects seasonTitle, seasonThumbnail and broadcastDate to be present for all instances of . However, a season with seasonNumber alone is viable. For example, the following season in e67004c-0.xml:

            <seasonNumber>1</seasonNumber>

gets converted to an intermediate pubrss-2-amgrss output xml as follows:

         <amg:season>
            <amg:seasonNumber>1</amg:seasonNumber>
         </amg:season>

I think the above season specification should pass validation. Hence, I propose minOccurs = 0 and maxOccurs = 1 for the following season attributes:

        <xs:element name="seasonTitle" minOccurs="0" maxOccurs="1" type="tns:myString" />
        <xs:element name="seasonThumbnail" minOccurs="0" maxOccurs="1" type="tns:myString" />
        <xs:element name="broadcastDate" minOccurs="0" maxOccurs="1" type="xs:gYear" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants