Fix detecting text direction with astral plane character

See amake/orgro#135
amake · Jan 29, 2025 · 170ec00 · 170ec00
1 parent 17adba9
commit 170ec00
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/src/util/bidi.dart b/lib/src/util/bidi.dart
@@ -27,7 +27,7 @@ class OrgBidiDetectionSerializer extends OrgSerializer {
   void write(String str) {
     if (canceled) return;
 
-    final idx = str.indexOf(UnicodeCharMatcher.bidiStrong());
+    final idx = UnicodeCharMatcher.bidiStrong().firstIndexIn(str);
     if (idx != -1) {
       canceled = true;
       strongChar = str.codeUnitAt(idx);

diff --git a/test/bidi_test.dart b/test/bidi_test.dart
@@ -29,4 +29,9 @@ void main() {
     final textDirection = node.detectTextDirection();
     expect(textDirection, TextDirection.ltr);
   });
+  test('astral plane', () {
+    final node = OrgPlainText('🌍');
+    final textDirection = node.detectTextDirection();
+    expect(textDirection, isNull);
+  });
 }