-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for custom prefixes for i18n routing #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amannn
changed the title
Add support in middleware
feat: Add support for custom prefixes
May 23, 2024
amannn
changed the title
feat: Add support for custom prefixes
feat: Add support for custom prefixes for i18n routing
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #653
Information
The
localePrefix
option forcreateMiddleware
as well as the navigation APIs now not only accepts a string, but an object where custom prefixes can be added per locale:In addition to this implementation, I've restructured the routing docs to discuss config options that are shared among the middleware and navigation APIs on a single page. We might expand on this in the future (see below).
See the docs.
Important: As mentioned in the docs, you might have to adjust your middleware matcher to handle the custom prefixes.
Changes
Link
(<Link href="about" />
)import {Pathnames} from 'next-intl/navigation'
in favor ofimport {Pathnames} from 'next-intl/routing'
Potential future changes
I'm considering adding an API like
const routing = defineRouting({locales: ['en', 'de'], ...})
to gather all routing-related config. This could be passed ascreateMiddleware({routing, ...})
(see #779).(also resolves #940)