-
-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add async requestLocale
param to getRequestConfig
for Next.js 15 support
#1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions` can receive a locale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Next.js is switching
headers()
to beasync
, thelocale
that is passed togetRequestConfig
needs to be replaced by an awaitable alternative. Note that this is only relevant for your app in case you're using i18n routing.tldr;
Switch to the new API and call it a day:
If your app worked well before, then this is a 1:1 switch and will get your app in shape for Next.js 15.
Details
The new
requestLocale
parameter also offered a chance to get in some enhancements for edge cases that were previously harder to support. Therefore, the following migration is generally recommended:Before:
After:
The differences are:
requestLocale
is a promise that needs to be awaitedundefined
—therefore a default should be supplied. The default assignment allows handling cases where an error would be thrown previously, e.g. when using APIs likeuseTranslations
on a global language selection page atapp/page.tsx
.locale
should be returned (since you can now adjust it in the function body).notFound()
in response to an invalid[locale]
param inapp/[locale]/layout.tsx
instead of ini18n/request.ts
. This unlocks another use case, where APIs likeuseTranslations
can now be used on a globalapp/not-found.tsx
page.See also the updated getting started docs.
Note that this change is non-breaking, but the synchronously available
locale
is now considered deprecated and will be removed in a future major version.Contributes to #1375
Addresses #1355