feat!: Inherit context in case nested NextIntlClientProvider instances are present
#1413
+144
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amannn
commented
Oct 9, 2024
| messages: messages || prevContext?.messages, | ||
| now: now || prevContext?.now, | ||
| onError: onError || prevContext?.onError, | ||
| timeZone: timeZone || prevContext?.timeZone |
There was a problem hiding this comment.
Doesn't minify terribly well, but can't really think of a better solution …
amannn
changed the title
amannn
commented
Oct 9, 2024
amannn
changed the title
NextIntlClientProvider ancestors are present
amannn
changed the title
NextIntlClientProvider ancestors are presentNextIntlClientProvider instances are present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have nested providers, previously only the configuration of the innermost one would be applied.
With this change, configuration is now passed from one provider to the next, while allowing to override individual props. This simplifies the configuration of
onErrorandgetMessageFallbackif you're using those (see proposed docs).Breaking change: There's a very rare chance that this change affects your app, but in case you've previously relied on providers not inheriting from each other, you now have to reset props manually in case you want to retain the previous behavior.