-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing deprecation warnings for next-intl@4.0
#1485
Open
amannn
wants to merge
7
commits into
main
Choose a base branch
from
amannn-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+31
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amannn
commented
Oct 29, 2024
packages/next-intl/src/server/react-server/getRequestConfig.tsx
Outdated
Show resolved
Hide resolved
amannn
changed the title
fix: Update JSDoc comment for
fix: Add warning for missing returned Oct 29, 2024
getRequestConfig
locale
from getRequestConfig
amannn
changed the title
fix: Add warning for missing returned
fix: Add missing deprecation warnings for Nov 19, 2024
locale
from getRequestConfig
next-intl@4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing deprecation warnings:
locale
was returned fromgetRequestConfig
(ref)next-intl
in a Client Component without aNextIntlClientProvider
ancestor being present (ref)TODO:
next-intl@4
#1412 first to see if we need other deprecations