Improved: variable name of sortOptions and removed unused import (hot…

…wax#171)
amansinghbais · Dec 11, 2023 · ff4dc89 · ff4dc89
1 parent 61ae3ba
commit ff4dc89
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/views/Picklist-Detail.vue b/src/views/Picklist-Detail.vue
@@ -10,7 +10,7 @@
       <ion-content>
         <ion-list>
           <ion-radio-group :value="picklistItemSortBy" @ionChange="updateSortBy($event)">
-            <ion-item v-for="option in sortBy" :key="option.value">
+            <ion-item v-for="option in sortOptions" :key="option.value">
               <ion-radio slot="start" :value="option.value"/>
               <ion-label>{{ $t(option.name) }}</ion-label>
             </ion-item>
@@ -95,7 +95,6 @@ import { translate } from '@/i18n'
 import { showToast } from '@/utils';
 import Scanner from '@/components/Scanner'
 import { useRouter, onBeforeRouteLeave } from 'vue-router';
-import emitter from '@/event-bus';
 
 export default defineComponent({
   name: 'PicklistDetail',
@@ -132,7 +131,7 @@ export default defineComponent({
     return {
       picklistGroup: [],
       lastScannedId: '',
-      sortBy: JSON.parse(process.env.VUE_APP_PICKLISTS_SORT_OPTIONS)
+      sortOptions: JSON.parse(process.env.VUE_APP_PICKLISTS_SORT_OPTIONS)
     }
   },
   props: ['id'],

diff --git a/src/views/Settings.vue b/src/views/Settings.vue
@@ -87,7 +87,7 @@
           <ion-item lines="none">
             <ion-label>{{ $t("Sort by") }}</ion-label>
             <ion-select interface="popover" :value="picklistItemSortBy" @ionChange="updateSortBy($event)">
-              <ion-select-option v-for="option in sortBy" :key="option.value" :value="option.value" >{{ option.name }}</ion-select-option>
+              <ion-select-option v-for="option in sortOptions" :key="option.value" :value="option.value" >{{ option.name }}</ion-select-option>
             </ion-select>
           </ion-item>
         </ion-card>
@@ -133,7 +133,7 @@ export default defineComponent({
       baseURL: process.env.VUE_APP_BASE_URL,
       appInfo: (process.env.VUE_APP_VERSION_INFO ? JSON.parse(process.env.VUE_APP_VERSION_INFO) : {}) as any,
       appVersion: "",
-      sortBy: JSON.parse(process.env.VUE_APP_PICKLISTS_SORT_OPTIONS)
+      sortOptions: JSON.parse(process.env.VUE_APP_PICKLISTS_SORT_OPTIONS)
     };
   },
   computed: {