Skip to content

Fixes #713 by always using latest version of Jinja2 #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixes #713 by always using latest version of Jinja2 #715

wants to merge 2 commits into from

Conversation

sporniket
Copy link
Contributor

(another experiment to see what break)

@sporniket sporniket mentioned this pull request Sep 20, 2022
Closed
@sporniket
Copy link
Contributor Author

This alternative breaks the same tests than #714

@sporniket
Copy link
Contributor Author

List of broken tests :

2022-09-20T04:52:28.1240730Z ======================================================================
2022-09-20T04:52:28.1241626Z FAIL: test_distance (tests.test_lib_coding.GrayCoderTestCase)
2022-09-20T04:52:28.1242468Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1242833Z Traceback (most recent call last):
2022-09-20T04:52:28.1243565Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_coding.py", line 127, in test_distance
2022-09-20T04:52:28.1244118Z     self.assertFormal(spec, mode="prove")
2022-09-20T04:52:28.1244547Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1244973Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1245335Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1245538Z 
2022-09-20T04:52:28.1245545Z 
2022-09-20T04:52:28.1245684Z ======================================================================
2022-09-20T04:52:28.1246038Z FAIL: test_reversible (tests.test_lib_coding.GrayCoderTestCase)
2022-09-20T04:52:28.1246588Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1246963Z Traceback (most recent call last):
2022-09-20T04:52:28.1247608Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_coding.py", line 123, in test_reversible
2022-09-20T04:52:28.1248035Z     self.assertFormal(spec, mode="prove")
2022-09-20T04:52:28.1248474Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1248890Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1249234Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1249435Z 
2022-09-20T04:52:28.1249443Z 
2022-09-20T04:52:28.1249914Z ======================================================================
2022-09-20T04:52:28.1250270Z FAIL: test_async (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1250798Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1251150Z Traceback (most recent call last):
2022-09-20T04:52:28.1251614Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 279, in test_async
2022-09-20T04:52:28.1252192Z     self.check_async_fifo(AsyncFIFO(width=8, depth=4))
2022-09-20T04:52:28.1252667Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 276, in check_async_fifo
2022-09-20T04:52:28.1253073Z     mode="hybrid", depth=fifo.depth * 4 + 1)
2022-09-20T04:52:28.1253501Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1253915Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1254271Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1254457Z 
2022-09-20T04:52:28.1254465Z 
2022-09-20T04:52:28.1254603Z ======================================================================
2022-09-20T04:52:28.1254963Z FAIL: test_async_buffered (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1255490Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1255839Z Traceback (most recent call last):
2022-09-20T04:52:28.1256286Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 282, in test_async_buffered
2022-09-20T04:52:28.1256741Z     self.check_async_fifo(AsyncFIFOBuffered(width=8, depth=4))
2022-09-20T04:52:28.1257222Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 276, in check_async_fifo
2022-09-20T04:52:28.1257629Z     mode="hybrid", depth=fifo.depth * 4 + 1)
2022-09-20T04:52:28.1258041Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1258449Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1258799Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1258996Z 
2022-09-20T04:52:28.1259004Z 
2022-09-20T04:52:28.1259140Z ======================================================================
2022-09-20T04:52:28.1259488Z FAIL: test_sync_buffered_pot (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1260020Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1260384Z Traceback (most recent call last):
2022-09-20T04:52:28.1260904Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 261, in test_sync_buffered_pot
2022-09-20T04:52:28.1261365Z     self.check_sync_fifo(SyncFIFOBuffered(width=8, depth=4))
2022-09-20T04:52:28.1261840Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 243, in check_sync_fifo
2022-09-20T04:52:28.1262224Z     mode="bmc", depth=fifo.depth + 1)
2022-09-20T04:52:28.1262633Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1263045Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1263402Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1263603Z 
2022-09-20T04:52:28.1263610Z 
2022-09-20T04:52:28.1263749Z ======================================================================
2022-09-20T04:52:28.1264103Z FAIL: test_sync_buffered_potm1 (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1264644Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1265006Z Traceback (most recent call last):
2022-09-20T04:52:28.1265471Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 267, in test_sync_buffered_potm1
2022-09-20T04:52:28.1265908Z     self.check_sync_fifo(SyncFIFOBuffered(width=8, depth=3))
2022-09-20T04:52:28.1266378Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 243, in check_sync_fifo
2022-09-20T04:52:28.1266763Z     mode="bmc", depth=fifo.depth + 1)
2022-09-20T04:52:28.1267181Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1267574Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1267929Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1268133Z 
2022-09-20T04:52:28.1268142Z 
2022-09-20T04:52:28.1268277Z ======================================================================
2022-09-20T04:52:28.1268710Z FAIL: test_sync_buffered_potp1 (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1269230Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1269593Z Traceback (most recent call last):
2022-09-20T04:52:28.1270047Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 264, in test_sync_buffered_potp1
2022-09-20T04:52:28.1270495Z     self.check_sync_fifo(SyncFIFOBuffered(width=8, depth=5))
2022-09-20T04:52:28.1270948Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 243, in check_sync_fifo
2022-09-20T04:52:28.1271337Z     mode="bmc", depth=fifo.depth + 1)
2022-09-20T04:52:28.1271755Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1272271Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1272586Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1272769Z 
2022-09-20T04:52:28.1272777Z 
2022-09-20T04:52:28.1272905Z ======================================================================
2022-09-20T04:52:28.1273235Z FAIL: test_sync_fwft_npot (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1273721Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1274043Z Traceback (most recent call last):
2022-09-20T04:52:28.1274456Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 252, in test_sync_fwft_npot
2022-09-20T04:52:28.1274864Z     self.check_sync_fifo(SyncFIFO(width=8, depth=5, fwft=True))
2022-09-20T04:52:28.1275299Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 243, in check_sync_fifo
2022-09-20T04:52:28.1275643Z     mode="bmc", depth=fifo.depth + 1)
2022-09-20T04:52:28.1276028Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1276411Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1276725Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1276913Z 
2022-09-20T04:52:28.1276920Z 
2022-09-20T04:52:28.1277045Z ======================================================================
2022-09-20T04:52:28.1277623Z FAIL: test_sync_fwft_pot (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1278151Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1278502Z Traceback (most recent call last):
2022-09-20T04:52:28.1278945Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 249, in test_sync_fwft_pot
2022-09-20T04:52:28.1279388Z     self.check_sync_fifo(SyncFIFO(width=8, depth=4, fwft=True))
2022-09-20T04:52:28.1279857Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 243, in check_sync_fifo
2022-09-20T04:52:28.1280227Z     mode="bmc", depth=fifo.depth + 1)
2022-09-20T04:52:28.1280647Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1281058Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1281417Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1281618Z 
2022-09-20T04:52:28.1281625Z 
2022-09-20T04:52:28.1281748Z ======================================================================
2022-09-20T04:52:28.1282107Z FAIL: test_sync_not_fwft_npot (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1282631Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1282994Z Traceback (most recent call last):
2022-09-20T04:52:28.1283433Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 258, in test_sync_not_fwft_npot
2022-09-20T04:52:28.1283881Z     self.check_sync_fifo(SyncFIFO(width=8, depth=5, fwft=False))
2022-09-20T04:52:28.1284351Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 243, in check_sync_fifo
2022-09-20T04:52:28.1284735Z     mode="bmc", depth=fifo.depth + 1)
2022-09-20T04:52:28.1285133Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1285606Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1285961Z AssertionError: Formal verification failed:
2022-09-20T04:52:28.1286163Z 
2022-09-20T04:52:28.1286171Z 
2022-09-20T04:52:28.1286307Z ======================================================================
2022-09-20T04:52:28.1286651Z FAIL: test_sync_not_fwft_pot (tests.test_lib_fifo.FIFOFormalCase)
2022-09-20T04:52:28.1287177Z ----------------------------------------------------------------------
2022-09-20T04:52:28.1287535Z Traceback (most recent call last):
2022-09-20T04:52:28.1287987Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 255, in test_sync_not_fwft_pot
2022-09-20T04:52:28.1288417Z     self.check_sync_fifo(SyncFIFO(width=8, depth=4, fwft=False))
2022-09-20T04:52:28.1288888Z   File "/home/runner/work/amaranth/amaranth/tests/test_lib_fifo.py", line 243, in check_sync_fifo
2022-09-20T04:52:28.1289277Z     mode="bmc", depth=fifo.depth + 1)
2022-09-20T04:52:28.1289831Z   File "/home/runner/work/amaranth/amaranth/tests/utils.py", line 82, in assertFormal
2022-09-20T04:52:28.1290226Z     self.fail("Formal verification failed:\n" + stdout)
2022-09-20T04:52:28.1290585Z AssertionError: Formal verification failed:

@whitequark
Copy link
Member

Neither of these probably break any tests, it's an update to yowasp-sby that is incompatible with Python 3.7. The main branch is just as broken.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2022 •
edited
Loading

Codecov Report

Merging #715 (0ff2294) into main (9a5a614) will decrease coverage by 0.23%.
The diff coverage is 19.51%.

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   81.22%   80.99%   -0.24%     
==========================================
  Files          49       49              
  Lines        6467     6483      +16     
  Branches     1526     1747     +221     
==========================================
- Hits         5253     5251       -2     
- Misses       1021     1039      +18     
  Partials      193      193
Impacted Files Coverage Δ
amaranth/_toolchain/cxx.py 95.12% <ø> (ø)
amaranth/build/plat.py 25.97% <0.00%> (-1.47%) ⬇️
amaranth/tracer.py 90.24% <80.00%> (+1.05%) ⬆️
amaranth/_toolchain/yosys.py 59.13% <100.00%> (-1.89%) ⬇️
amaranth/__init__.py 66.66% <0.00%> (-22.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@whitequark
Copy link
Member

See #713 (comment).

@whitequark whitequark closed this Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sporniket @whitequark @codecov-commenter