-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement RFC 30: Component metadata. #978
Conversation
39dfb27
to
23bb98c
Compare
Rebased to current main branch. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #978 +/- ##
==========================================
+ Coverage 90.48% 90.93% +0.44%
==========================================
Files 43 45 +2
Lines 10864 10640 -224
Branches 2660 2596 -64
==========================================
- Hits 9830 9675 -155
+ Misses 855 777 -78
- Partials 179 188 +9 ☔ View full report in Codecov by Sentry. |
Update to track changes to the RFC. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. The lib.meta
module still needs reference documentation, and lib.wiring
module's reference documentation needs to be expanded, before the feature is considered fully done.
Rebased on current main. Updated |
Agreed. |
I've added a task list to the tracking issue: #1047 (comment) |
876e525
to
38f20b2
Compare
Updated with documentation and changelog entry. The CI link check will fail until the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c254cb4
to
8057b60
Compare
Co-authored-by: Catherine <whitequark@whitequark.org>
496432e
No description provided.