Add RFC for Choice.

[wanda-phi]

Rendered

[whitequark]

Guard syntax bikeshed:

1. Just stuff it in the list:

Choice(foo, {
  (1, guard): bar
})

2. Context manager:

with Choice(foo) as c:
    with c.Case(1, if=guard):
        c.eq(bar)

3. Explicit Guard primitive:

Choice(foo, {
  Guard(1, if=guard): bar
})

with m.Switch(foo):
    with m.Case(Guard(1, if=guard)):
        ...

(I don't love any of these. They're also all backward compatible.)

[wanda-phi]

Guard syntax bikeshed:

1. Just stuff it in the list:

Choice(foo, {
  (1, guard): bar
})

That won't work (Value is not hashable)

[whitequark]

In addition, the existing Mux expression is made valid on the left-hand side of an assignment, as if it was lowered as follows:

def Mux(sel, val1, val0):
    return Choice(a).case(1, val1).default(val0)

Shouldn't it be the opposite?

def Mux(sel, val1, val0):
    return Choice(a).case(0, val0).default(val1)

[wanda-phi]

In addition, the existing Mux expression is made valid on the left-hand side of an assignment, as if it was lowered as follows:

def Mux(sel, val1, val0):
    return Choice(a).case(1, val1).default(val0)

Shouldn't it be the opposite?

def Mux(sel, val1, val0):
    return Choice(a).case(0, val0).default(val1)

fixed, thanks

[whitequark]

We have discussed this RFC on the 2024-07-01 weekly meeting. The disposition was to merge.

[whitequark]

Thanks @wanda-phi for your work!