cleaning up and improving the CI/CD pipeline #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tcurdt I'm glad you're smarter than me on htis stuff! IDK no clue what is going on but excited to pull :) Dumb Q: not every commit has a new/different version number tho, does that matter? (nor do they need to always be published) |
|
@hillct will you please email me the Docker Hub username & credentials? Thank you! |
|
As far as I know, your account is an administrator there
…On Tue, Sep 7, 2021, 18:57 Mark Nadal ***@***.***> wrote:
@hillct <https://github.com/hillct> will you please email me the Docker
Hub username & credentials? Thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1122 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABHNR2WQ3PSAKN3BMM4YEDUA2KGPANCNFSM5C7TAKFQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cleaned up the CD pipeline a little.
The docker build is now a two-step build. The label passing might need some more testing though.
The CI runs on all pushes. If the tag starts with
vit's a new version - and by that definition a new release. Note: Until now the version numbers were just numbers0.2019.413. It would be good if we could switch to thevprefix. So a new release could be for examplev0.2021.001.The tag will create a new github release, which in turn trigger all the release distribution workflows.
For now that's npm and dockerhub. It's easy to add more.