Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SEA: .auth, .certify, check.pub #1130

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Improve SEA: .auth, .certify, check.pub #1130

merged 3 commits into from
Sep 6, 2021

Conversation

mimiza
Copy link
Contributor

@mimiza mimiza commented Sep 5, 2021

In this PR:

  • user.is.alias now only has username string or pub string, not priv/epriv.
  • SEA.certify "blacklist" now renamed to "block": now accepts more keys "block", "ban". This feature is still not working because gun is returning a permanently unresolved Promise, so it's unit test is currently skipped.
  • Improve check.pub certVerify logic

- Improve certify() logic
- "Blacklist" renamed to "block". BLACK LIVES MATTER!
- Fix user.is.alias, now it doesn't contain full pair any more.
The "block" (former "blacklist") feature is not working yet (due to a bug in gun)
@amark
Copy link
Owner

amark commented Sep 6, 2021

WOW @mimiza you're a hero!!!!!! 🔥 🔥 🔥 🔥 🔥 ⚡ ⚡ ⚡ ⚡ ⚡ 🎉 🎉 🎉 🎉 🎉 🎉 <3 <3 <3

@amark amark merged commit 63b0043 into amark:master Sep 6, 2021
@mimiza
Copy link
Contributor Author

mimiza commented Sep 6, 2021

Thanks for merging Mark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants