Fix: type error shown when using generated keypair #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- a callback is optional, because we could just use the async/await methodology to recieve the keypair - when signing only `priv` is used - when verifying only `pub` is used - both when encrypting/decrypting only `epriv` is used
|
@pepyta 👏 ⚡ 🔥 🙏 🎉 👏 ⚡ 🔥 🙏 🎉 👏 ⚡ 🔥 🙏 🎉 thank goodness someone here knows TypeScript! It is all community contributed. Thank you, pulling right away - would you be willing to correct/fix anything else & refactor it?? |
|
(I mean, not your PR, but the rest of the TypeScript stuff) |
|
Sure, but I will create separate PRs for those fixes. |
|
Btw I think a full Typescript reimplementation would be beneficial. What do you think about that? @amark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in the type declaration files, where we define SEA's functions.
These functions use and result an
IGunCryptoKeyPair, but in the declaration files we useCryptoKeyPair.The IGunCryptoKeyPair fields looks like these:
And the CryptoKeyPair interface's fields looks like these: