Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✂️ Path shortened ! #1141

Merged
merged 10 commits into from
Oct 30, 2021
Merged

✂️ Path shortened ! #1141

merged 10 commits into from
Oct 30, 2021

Conversation

noctisatrae
Copy link
Contributor

You can now shorten the path in gun.

@noctisatrae
Copy link
Contributor Author

... Merge conflict...

@noctisatrae
Copy link
Contributor Author

That's the first I've ever solved!

@amark
Copy link
Owner

amark commented Oct 15, 2021

Looking good @noctisatrae ! Tho chokidar not suppose to be added as a dependency, remember, just try{ require('chokidar') } catch (e) { console.log("please npm install chokidar first!") } or something like that. So please remove it from package.json and then we'll merge! Sorry I was gone for so long. Exciting to see progress!!!! Thanks!!!

@noctisatrae
Copy link
Contributor Author

@amark Could you check another time ?

@amark
Copy link
Owner

amark commented Oct 30, 2021

@noctisatrae 🔥 🔥 🔥 🔥 👏 👏 👏 👏 ⚡ ⚡ ⚡ ⚡ w0000! Perfect! Merging :)

@amark amark merged commit 3b8eb16 into amark:master Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants