Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there!
This PR fixes this issue #1155, I've rewritten the YSON functionality and made it use a modified version of yieldable-json so it produces very similar output as to how the previous YSON implementation used to so values that are of type "function" are output as
null
in the JSON string, etc...I've also run some tests both in our project and the Mocha tests that are under the
/test
folder and it seems like the new YSON implementation is fully backward-compatible with the existing code that utilizes it :)Let me know if you have any questions or if anything needs to be modified!
Thanks!