Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix offer and answer payload for webrtc #1210

Merged
merged 1 commit into from
Feb 19, 2022
Merged

Fix offer and answer payload for webrtc #1210

merged 1 commit into from
Feb 19, 2022

Conversation

timaschew
Copy link
Contributor

No description provided.

@timaschew timaschew changed the title Fix offer payload Fix offer and answer payload Feb 18, 2022
@timaschew timaschew changed the title Fix offer and answer payload Fix offer and answer payload for webrtc Feb 18, 2022
@amark
Copy link
Owner

amark commented Feb 19, 2022

Oooooooooooh, this is related to the other bug. Which is actually already fixed in main, so this isn't needed. Sorry :( :( :( lol. But its harmless & I want to encourage contribution/credit so gonna pull anyways I hope that's ok? (then in a few months, probably sneakily delete the code lines 😬 )

@amark amark merged commit 1051e47 into amark:master Feb 19, 2022
@timaschew
Copy link
Contributor Author

Which bug do you mean in main?
Is that related to the issue when sending putting \n in the payload which is synced in the db?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timaschew @amark