Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow {pair.pub} to login with pass #1233

Merged
merged 7 commits into from
Apr 29, 2022
Merged

Allow {pair.pub} to login with pass #1233

merged 7 commits into from
Apr 29, 2022

Conversation

bmatusiak
Copy link
Collaborator

Allow {pair.pub} to login with pass

@bmatusiak
Copy link
Collaborator Author

with a fix for s3 (that affected Heroku) #1232

@amark
Copy link
Owner

amark commented Apr 29, 2022

Oh nice! Epic. I didn't go line for line but it looked like roughly the right places for stuff to be done. (And since this is security stuff, NOTHING looked weird/fishy. Yay!)

Would you be willing to add a test for this? test/sea/sea.js copy one of the it functions (ones in the middle may be easier to reuse) then swap in sample login code/test. Then open ../mocha.html in browser from file or run mocha command line in repo root.

thank you thank you thank you!

@bmatusiak
Copy link
Collaborator Author

      ✓ login users (560ms)
      ✓ logout, login via {pub} (399ms)
      ✓ save data (273ms)

@amark
Copy link
Owner

amark commented Apr 29, 2022

👏 👏 👏 🔥 🔥 🔥 @bmatusiak !!!

@amark amark merged commit e3eaf5e into amark:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants