Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master into RAD #702

Merged
merged 158 commits into from
Feb 6, 2019
Merged

Master into RAD #702

merged 158 commits into from
Feb 6, 2019

Conversation

amark
Copy link
Owner

@amark amark commented Feb 6, 2019

No description provided.

amark and others added 23 commits January 15, 2019 10:51
Fix apparent copy/paste error in rindexed.js
`node-webcrypto-ossl` is a native Node package, and will only be used in a very specific instance (using SEA from Node).

In my case, and I suppose in many others', SEA in Node will never be used.

I'd like to have that dependency made optional, since a failure to require it [is already handled](https://github.com/amark/gun/blob/535d6569fcff380faefe8ffafbeb658a1635b74f/sea.js#L183). Furthermore on Windows it requires the entire native build toolchain to be installed, which is not ideal for such a small feature.
Make node-webcrypto-ossl an optional dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.