Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignored option. #79

Merged
merged 3 commits into from
Dec 22, 2016
Merged

Add ignored option. #79

merged 3 commits into from
Dec 22, 2016

Conversation

wtgtybhertgeghgtwtg
Copy link
Collaborator

Retrying #77 for CI.

@amasad
Copy link
Owner

amasad commented Dec 21, 2016

strange, there is still no ci. Maybe you haven't rebased?

@wtgtybhertgeghgtwtg
Copy link
Collaborator Author

wtgtybhertgeghgtwtg commented Dec 21, 2016

@amasad
Copy link
Owner

amasad commented Dec 21, 2016

oh look, it's somehow now running

@amasad
Copy link
Owner

amasad commented Dec 21, 2016

screen shot 2016-12-20 at 7 44 05 pm

@wtgtybhertgeghgtwtg
Copy link
Collaborator Author

Added fix for watchman_walker. CircleCI doesn't seem to want to trigger when I merge a PR.

@wtgtybhertgeghgtwtg
Copy link
Collaborator Author

Would you trigger the CI for e6dfd27?

var matched;
if (globs.length) {
for (var i = 0; i < globs.length; i++) {
if (minimatch(relativePath, globs[i], {dot: dot})) {
console.log(relativePath, !doIgnore(relativePath));
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you please remove the console.log

@amasad
Copy link
Owner

amasad commented Dec 22, 2016

I don't know why it's acting up on this PR. I'll just merge it and have it test on master after you fix my comment.

@wtgtybhertgeghgtwtg
Copy link
Collaborator Author

console.log removed. I can't believe I forgot to take that out.

@amasad amasad merged commit a1271a3 into amasad:master Dec 22, 2016
@wtgtybhertgeghgtwtg
Copy link
Collaborator Author

If this is passing the CI, can it be published soon? It's needed for webpack/watchpack#41.

@amasad
Copy link
Owner

amasad commented Dec 24, 2016

@wtgtybhertgeghgtwtg published: v1.5
Can you document the feature in Readme? You already have commit access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants