Skip to content
This repository has been archived by the owner on Mar 27, 2020. It is now read-only.

move TaskRoleArn out of ContainerDefinitions #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

move TaskRoleArn out of ContainerDefinitions #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion workshop3/hints/final-service.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ Resources:
Type: AWS::ECS::TaskDefinition
Properties:
Family: iridium
TaskRoleArn: !Ref ECSTaskRole
ContainerDefinitions:
- Name: iridium
Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${Repository}:${Tag}
Expand All @@ -80,7 +81,6 @@ Resources:
Environment:
- Name: Tag
Value: !Ref Tag
TaskRoleArn: !Ref ECSTaskRole
LogConfiguration:
LogDriver: awslogs
Options:
Expand Down
2 changes: 1 addition & 1 deletion workshop3/hints/new-service.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ Resources:
Type: AWS::ECS::TaskDefinition
Properties:
Family: iridium
TaskRoleArn: !Ref ECSTaskRole
ContainerDefinitions:
- Name: iridium
Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${Repository}:${Tag}
Expand All @@ -74,7 +75,6 @@ Resources:
Environment:
- Name: Tag
Value: !Ref Tag
TaskRoleArn: !Ref ECSTaskRole
LogConfiguration:
LogDriver: awslogs
Options:
Expand Down
2 changes: 1 addition & 1 deletion workshop3/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,7 @@
Type: AWS::ECS::TaskDefinition
Properties:
Family: iridium
<b>TaskRoleArn: !Ref ECSTaskRole </b>
ContainerDefinitions:
- Name: iridium
Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${Repository}:${Tag}
Expand All @@ -954,7 +955,6 @@
Environment:
- Name: Tag
Value: !Ref Tag
<b>TaskRoleArn: !Ref ECSTaskRole </b>
LogConfiguration:
LogDriver: awslogs
Options:
Expand Down
2 changes: 1 addition & 1 deletion workshop3/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,6 +934,7 @@ TaskDefinition:
Type: AWS::ECS::TaskDefinition
Properties:
Family: iridium
<b>TaskRoleArn: !Ref ECSTaskRole </b>
ContainerDefinitions:
- Name: iridium
Image: !Sub ${AWS::AccountId}.dkr.ecr.${AWS::Region}.amazonaws.com/${Repository}:${Tag}
Expand All @@ -944,7 +945,6 @@ TaskDefinition:
Environment:
- Name: Tag
Value: !Ref Tag
<b>TaskRoleArn: !Ref ECSTaskRole </b>
LogConfiguration:
LogDriver: awslogs
Options:
Expand Down