This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Fix NameError for 412Error on 412 without body
#65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
>> Aws::S3.new.head_object(if_unmodified_since: '2014-06-09 12:44:21 +0900', bucket: '...', key: '...') NameError: wrong constant name 412Error
|
note: get_object returns body for 412 error, so it succeeds |
trevorrowe
added a commit
that referenced
this pull request
Jun 12, 2014
Fix NameError for `412Error` on 412 without body
|
Thanks! |
trevorrowe
added a commit
that referenced
this pull request
Jun 18, 2014
References: #49, #64, #65, #66, #67, aws/aws-sdk-ruby#455, aws/aws-sdk-ruby#529
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by the way, current implementation of
ErrorHandler#.error_code_for_empty_responsemakes invalid string for constant name (ex:412Error)when pre-defined error constant not found, is this expected?