Skip to content
This repository has been archived by the owner on Mar 31, 2021. It is now read-only.

Commit

Permalink
Fix: use column name if alias is an empty string (#84)
Browse files Browse the repository at this point in the history
* add empty string case for alias

* add 1.9.0.2 release notes
  • Loading branch information
joshuali925 authored Jul 6, 2020
1 parent 6ed5068 commit 46bb53e
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion public/components/Main/main.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ export function getQueryResultsForTable(queryResults: ResponseDetail<string>[]):
} catch (e) {
console.log('No alias for field ' + field);
} finally {
fields[id] = alias == null ? _.get(field, 'name') : alias;
fields[id] = !alias ? _.get(field, 'name') : alias;
}
}
databaseFields = fields;
Expand Down
2 changes: 1 addition & 1 deletion release-notes/sql-workbench.release-notes-1.9.0.1.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 2020-06-23 Version 1.9.0.1 (Current)
## 2020-06-23 Version 1.9.0.1

### Bug Fixes
- Fix: Kibana did not load properly ([#81](https://github.com/opendistro-for-elasticsearch/sql-workbench/pull/81))
4 changes: 4 additions & 0 deletions release-notes/sql-workbench.release-notes-1.9.0.2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
## 2020-07-06 Version 1.9.0.2 (Current)

### Bug Fixes
- Fix: use column name if alias is an empty string ([#84](https://github.com/opendistro-for-elasticsearch/sql-workbench/pull/84))

0 comments on commit 46bb53e

Please sign in to comment.