fix: Raise exception for probs with observable
#280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #280 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 1251 1253 +2
Branches 163 164 +1
=========================================
+ Hits 1251 1253 +2 ☔ View full report in Codecov by Sentry. |
AbeCoull
reviewed
Oct 24, 2024
| @@ -576,6 +576,8 @@ def translate_result_type( # noqa: C901 | |||
| observable = measurement.obs | |||
|
|
|||
| if return_type is ObservableReturnTypes.Probability: | |||
| if observable: | |||
| raise qml.DeviceError("Probability result type not supported for observables") | |||
There was a problem hiding this comment.
This looks to be causing some issues for the tests. Is this the expected outcome now?
There was a problem hiding this comment.
So at the moment the pl-device-tests are xfailing the hadamard gradient tests due to the incorrect results. We may instead need to xfail at a different location as now we get an error on execution, instead of on result comparison:
albi3ro
reviewed
Oct 25, 2024
Co-authored-by: Christina Lee <chrissie.c.l@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#279
Description of changes:
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.