Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure all tests use valid OpenQASM and upgrade to latest Braket SDK #45

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

rmshaffer
Copy link
Contributor

@rmshaffer rmshaffer commented Sep 23, 2024

Issue #, if available:
Resolves #34

Description of changes:
Ensure that all tests generate valid OpenQASM, mostly by removing usage of the reserved keyword angle and duration as parameter names. This unblocks upgrading to the latest released version of the Braket SDK, so this PR does that as well.

Testing done:
All unit tests pass. tox -e notebooks passes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rmshaffer rmshaffer requested a review from a team as a code owner September 23, 2024 21:17
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6943fe9) to head (0282612).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         2090      2090           
  Branches       345       345           
=========================================
  Hits          2090      2090           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rmshaffer rmshaffer merged commit a5044b7 into main Sep 24, 2024
17 checks passed
@rmshaffer rmshaffer deleted the rmshaffer/upgrade-bdk-version branch September 24, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests produce OpenQASM programs which use reserved keywords as variable names
2 participants