issue#196 Updating comparison report for non-equivalent struct #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgregg
previously approved these changes
Sep 1, 2020
| "Did not find matching field for " + ion_event_symbol_to_string(expected_field_name)); | ||
| ION_EXPECT_TRUE_WITH_INDEX(!(ION_ACTUAL_ARG->event_type == CONTAINER_END && ION_ACTUAL_ARG->depth == target_depth), | ||
| "Did not find matching field for " + ion_event_symbol_to_string(expected_field_name), | ||
| index_expected_container_start,index_actual_container_start); |
|
Added |
tgregg
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Worked on issue #196.
For comparing struct, we write CONTAINER_START event for lhs/rhs in comparison report if we can't find a key-value pair of the first struct in the second struct.
What I did
Added a helper function that sets comparison report's context to desire event's index (ION_EXPECT_TRUE_WITH_INDEX). When two structs are different, we use this new function to write the CONTAINER_START event on comparison report.