Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test Title from Python Client #2

Closed
almann opened this issue Apr 17, 2016 · 1 comment
Closed

Test Title from Python Client #2

almann opened this issue Apr 17, 2016 · 1 comment

Comments

@almann
Copy link
Contributor

almann commented Apr 17, 2016

Test Body from github module in Python
@almann
Copy link
Contributor Author

almann commented Apr 17, 2016

Test from PyGithub for importing issues.

@almann almann closed this as completed Apr 17, 2016
@toddjonker toddjonker mentioned this issue Jan 10, 2019
Closed
zslayton added a commit that referenced this issue Jun 16, 2021
@zslayton
Makes writeValueRecursively iterative
24648f0 
The method `_Private_IonWriterBase#writeValueRecursively` is
recursive in two senses:

1. It visits all of the children in the provided IonReader's
   current value recursively.
2. The method itself is implemented using recursion.

This patch modifies the implementation (#2) to be iterative,
eliminating a source of StackOverflowExceptions and offering
a modest reduction in CPU cost.
jobarr-amzn pushed a commit that referenced this issue Jun 16, 2021
@zslayton
Makes writeValueRecursively iterative (#368)
ca85095 
* Makes `writeValueRecursively` iterative

The method `_Private_IonWriterBase#writeValueRecursively` is
recursive in two senses:

1. It visits all of the children in the provided IonReader's
   current value recursively.
2. The method itself is implemented using recursion.

This patch modifies the implementation (#2) to be iterative,
eliminating a source of StackOverflowExceptions and offering
a modest reduction in CPU cost.

* Tweaked javadoc, removed parameter.

* Fixed comment.

Co-authored-by: Zack Slayton <zslayton@amazon.com>
@artemkach artemkach mentioned this issue Sep 4, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@almann