Use default module instead of $ion_encoding #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ion-11-encoding #1007 +/- ##
==================================================
Coverage ? 70.68%
Complexity ? 7336
==================================================
Files ? 214
Lines ? 29315
Branches ? 5276
==================================================
Hits ? 20720
Misses ? 6936
Partials ? 1659 ☔ View full report in Codecov by Sentry. |
tgregg
approved these changes
Dec 4, 2024
| @@ -2115,7 +2115,7 @@ private void setCheckpointBeforeUnannotatedTypeId() { | |||
| */ | |||
| private void setMarker(long endIndex, Marker markerToSet) { | |||
| if (parent != null && endIndex > parent.endIndex && parent.endIndex > DELIMITED_MARKER) { | |||
| throw new IonException("Value exceeds the length of its parent container."); | |||
| throw new IonException(String.format("Value [%s:%s] exceeds the length of its parent container [%s:%s].", peekIndex, endIndex, parent.startIndex, parent.endIndex)); | |||
There was a problem hiding this comment.
Suggested change
| throw new IonException(String.format("Value [%s:%s] exceeds the length of its parent container [%s:%s].", peekIndex, endIndex, parent.startIndex, parent.endIndex)); | |
| throw new IonException(String.format("Value [%d:%d] exceeds the length of its parent container [%d:%d].", peekIndex, endIndex, parent.startIndex, parent.endIndex)); |
src/main/java/com/amazon/ion/impl/IonReaderContinuableCoreBinary.java
Outdated
Show resolved
Hide resolved
tgregg
approved these changes
Dec 4, 2024
tgregg
approved these changes
Dec 4, 2024
tgregg
pushed a commit
that referenced
this pull request
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Changes
$ion_encodingto the default module as described in amazon-ion/ion-docs#369This does not implement any new functionality. It just makes the current functionality match the new syntax.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.