Prepare work before release beta version. #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheqianh
commented
Jun 22, 2021
| (_D('1.1999999999999999555910790149937383830547332763671875e0'), | ||
| b'1.1999999999999999555910790149937383830547332763671875'), | ||
| # (_D('1.1999999999999999555910790149937383830547332763671875e0'), | ||
| # b'1.1999999999999999555910790149937383830547332763671875'), |
There was a problem hiding this comment.
As discussed offline, C extension only supports 34 decimal digits. I comment this for beta version for now.
| timestamp(2016, 2, 2, 0, 0, 30, precision=TimestampPrecision.SECOND, | ||
| fractional_seconds=Decimal('0.7e-500')), | ||
| (b'2016-02-02T00:00:30.' + b'0' * 500 + b'7-00:00', b'2016-02-02T00:00:30.000000-00:00') | ||
| ) |
There was a problem hiding this comment.
As discussed offline, C extension only supports up to 6 timestamp precision. Mentioned this in doc and will fix this in the future release.
tgregg
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issues fix and integration/config script (
install.py) enhencement.Change Details:
Fixed an unit test failure. For value
$11::$12::$13, before we hardcoded\x0b\x0c($11::$12) for annotations since pure python LST always have annotation come first, now it may be\x0c\x0d($12::$13) as it satisfied some conditions such as C extension is enabled. (code here)Improved
install.py.setup.pyis the only entrance of the project no matter users check out from Github, install by pip or our dev package the project for release.building ion-candbinding C extension, So if someone run into issues when they setup C extension, they can still manually build ion-c and put it underion-python/, then runsetup.pyagain to setup C extension. So users can setup C extension easily as long as they know how to build ion-c.Fixed a segment fault. It's due to a very large field_name length, now C extension catches the exception before it crashes python. I changed the maximum length of a field name to 1000 now, and I opened an ion-python issue#153 to make it behavior better in the future. (code here)
Memory leak check and fix. I created a temporary value
temp, and releasepy_valueandpy_annotation(code here). I will create a different pull request for adding memory leak check to unit test.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.