Fix Bugs with emit_bare_values #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes it so that the emit_bare_values flag to the load_extension() method actually works. It does not plumb the flag up to the user APIs. Specifically: * Bare Decimals are correctly emitted instead of tuples * Values within a non-bare Sexp may now be bare themselves * None is correctly Increffed when emitted as a bare value I also patched a leak with ION_DECIMALs where the read decimal was not being freed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that the emit_bare_values flag to the
load_extension() method actually works. It does not plumb the
flag up to the user APIs.
Specifically:
I also patched a leak with ION_DECIMALs where the read decimal
was not being freed.
PR Note:
I'd like to see us expand what we emit as std python values, as I think
it will yield solid performance gains and I don't think most folks will
miss the "ion-ness". But... "most" is not "all" so I think we will need a
set of flags to allow users to specify where they sacrifice fidelity for
speed and convenience.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.