Implement Symbol as Text in C-extension #327
Merged
+54
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the IonPy value for a Symbol is IonPySymbol and the bare value is a SymbolToken. With the SYMBOL_AS_TEXT flag set, the IonPy value for a Symbol is IonPyText, and the bare value is str. This makes Symbol handling simpler if one only cares about the text value. It also improves load performance for symbols significantly. Symbols with undefined text cannot be emitted with this flag set and will raise exceptions.
tgregg
approved these changes
Dec 28, 2023
| assert value.ion_type == expected_ion_type | ||
|
|
||
|
|
||
| def test_undefined_symbol_text_as_text(): |
There was a problem hiding this comment.
Looks like this test might need
# This function only tests c extension
if not c_ext:
return
So that it doesn't fail on Pypy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the IonPy value for a Symbol is IonPySymbol and the bare
value is a SymbolToken. With the SYMBOL_AS_TEXT flag set, the IonPy
value for a Symbol is IonPyText, and the bare value is str.
This makes Symbol handling simpler if one only cares about the text
value. It also improves load performance for symbols significantly.
Symbols with undefined text cannot be emitted with this flag set and
will raise exceptions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.