Fix invalid memory access in ionc_write #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like PyPy 3.8 is failing due to ujson and rapidjson extension build issues.. 3.10 pypy on macos looks to be failing because of a linker option in rapidjson. |
We should defintely have checks that pass by default. I'm not concerned about the benchmark for those formats not working on PyPy. I think we were just benchmarking against plain old json in fact, and IIRC we had disabled pypy for those? If not, or if it got lost somehow, we should. |
rmarrowstone
approved these changes
Oct 18, 2024
This was referenced Oct 18, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #375
Description of changes:
The ionc extension had a few uninitialized pointers defined in
ionc_writethat would getPy_DECREF'd when the arguments provided where invalid. This was found with the feature added with #372, when an extra parameter was passed to track whether to print trialing commas or not.This PR initializes the values to NULL and changes the
Py_DECREFtoPy_XDECREFbecausePy_DECREFdoesn't handle NULL values. Unit tests were also added to ensure we're returning an exception and not blowing up in these cases.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.