Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts "changed PartialEq for struct for symmetry bug (#239)" #260

Merged
merged 1 commit into from
May 11, 2021

Conversation

almann
Copy link
Contributor

@almann almann commented May 11, 2021

Specifically does this because the squash merge was dirty and trampled
over the submodule edit.

This reverts commit f305aeb.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Specifically does this because the squash merge was dirty and trampled
over the submodule edit.

This reverts commit f305aeb.
@almann almann requested a review from desaikd May 11, 2021 18:42
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #260 (769595e) into main (f305aeb) will increase coverage by 0.03%.
The diff coverage is 88.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
+ Coverage   91.43%   91.47%   +0.03%     
==========================================
  Files          53       53              
  Lines        8006     8008       +2     
==========================================
+ Hits         7320     7325       +5     
+ Misses        686      683       -3     
Impacted Files Coverage Δ
src/value/mod.rs 89.43% <88.25%> (+0.70%) ⬆️
src/value/borrowed.rs 92.70% <100.00%> (-0.18%) ⬇️
src/value/owned.rs 92.74% <100.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f305aeb...769595e. Read the comment docs.

@almann almann merged commit a13699a into amazon-ion:main May 11, 2021
@almann almann deleted the revert branch May 11, 2021 18:55
marcbowes pushed a commit to marcbowes/ion-rust that referenced this pull request May 12, 2021
…" (amazon-ion#260)

Specifically does this because the squash merge was dirty and trampled
over the submodule edit.

This reverts commit f305aeb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants