Adds read/write support for system eexps, placeholders for remaining system macros #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Macros now impleement `Send`, allowing them to be shared across threads. This makes it possible for all readers and writers to share the same system macro table instance instead of allocating their own copy. * Adds a `SystemMacroAddress` type that is range-checked at creation. * Adds a `SystemAddress` variant to the `MacroIdRef` enum. * Adds `Opcode::from_byte` support for `SystemEExpression`. * `Parameter` and `Macro` now use `CompactString` to store their names, skipping all heap allocations in the common case.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## deny-old-idioms #862 +/- ##
===================================================
+ Coverage 77.83% 77.94% +0.11%
===================================================
Files 136 136
Lines 34021 34382 +361
Branches 34021 34382 +361
===================================================
+ Hits 26479 26800 +321
- Misses 5602 5626 +24
- Partials 1940 1956 +16 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on PR #861.
MacroTablenow implementsSend, allowing instances to be shared across threads. This made it possible for the system symbol table to be a singleton for all readers. To achieve this:Rcreferences to otherMacroinstances are nowArc. This incurs higher overhead for new macro definitions at compile time, but no overhead at usage time.ReaderandWriterinstantiation benefit by not having to create a new system macro table instance.Rc<str>instances have been replaced byCompactString, which doesn't allocate for strings that are<=24bytes long.$ion::<addr>and$ion::<name>e-expressions.0xEFsystem e-expressions.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.