Statically computes text value kind lookup table #894
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #892, the PR to port to
winnow
.I thought there might be a performance boost to be had by computing the mapping from a text value's first byte to the value's kind at compile time and using a lookup table at runtime. Strangely, it didn't change the performance at all--benchmark results are identical.
I'm inclined to merge this anyway just so people don't spend time following the same line of reasoning in the future. Subjectively, it's a bit tidier.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.