Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds experimental-location feature flag #910

Merged
merged 2 commits into from
Feb 19, 2025
Merged

Adds experimental-location feature flag #910

merged 2 commits into from
Feb 19, 2025

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Feb 18, 2025

Issue #, if available:

Description of changes:
This PR works on adding an experimental-location feature flag for the location-metadata implementation. This allows users to opt-in based on their performance requirements.

List of changes:

  • define experimnetal-location feature flag in the Cargo.toml.
  • add configuration wherever row and column properties are used or updated in the TextBuffer.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@desaikd desaikd requested review from zslayton and popematt February 18, 2025 23:20
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.54%. Comparing base (a7c30d4) to head (1116409).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #910   +/-   ##
=======================================
  Coverage   77.53%   77.54%           
=======================================
  Files         137      137           
  Lines       34283    34290    +7     
  Branches    34283    34290    +7     
=======================================
+ Hits        26583    26590    +7     
  Misses       5717     5717           
  Partials     1983     1983           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desaikd desaikd merged commit 28b8db7 into main Feb 19, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants