Add workflow to run evaluation on a subset of datasets #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evaluation Metrics
|
added 2 commits
November 29, 2024 17:08
Evaluation Metrics
|
Evaluation Metrics
|
Evaluation Metrics
|
abdulfatir
changed the title
abdulfatir
commented
Dec 1, 2024
added 2 commits
December 1, 2024 16:02
abdulfatir
changed the title
lostella
reviewed
Dec 2, 2024
lostella
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: This PR adds a workflow that will run the evaluation script on
chronos-bolt-smallfor a subset of datasets specified inci/evaluate/backtest_configs.yaml. After evaluation, a comment will be made on the PR. The workflow will only run if therun-evallabel is present on a PR. The end-to-end workflow has been split into two workflows:eval-model.yml: only has read access (can be run from forks). This will evaluate the model and upload the metrics CSV file as a Github artifact.eval-pr-comment.yml: has read and write access (can only be run when in themainbranch). This will be triggered when the first job finishes, will download the CSV from the eval job and make the comment. According to this post, splitting into two jobs as done here is the recommended and secure way to do this.NOTE: The first steps works as expected, but we can only test the second step after the merging because this workflow needs to be part of the
mainbranch for this to work.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.