Split input_transform into context_input_transform and label_input_transform
#82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdulfatir
changed the title
Config, Tokenizer, Pipelineinput_transform into context_input_transform and label_input_transform
lostella
reviewed
May 27, 2024
lostella
reviewed
May 27, 2024
| if length > self.config.context_length: | ||
| context = context[..., -self.config.context_length :] | ||
|
|
||
| token_ids, attention_mask, scale = self._input_transform(context=context) |
There was a problem hiding this comment.
I'm wondering: is _input_transform needed, or could context_input_transform just piggy-back on label_input_transform here?
lostella
reviewed
May 28, 2024
There was a problem hiding this comment.
I have a proposal for slightly shorter names. Don't hate me, names are hard:
context_input_transform->encode_contextlabel_input_transform->encode_labeloutput_transform->decode_samples
What do you think? Of course if we change names then docstrings are to be updated
|
In general, I don't disagree that names can be improved but I am wondering if |
lostella
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes: This splits
input_transformintocontext_input_transformandlabel_input_transform. Previously,input_transformwas being used for both context and label during training which would lead to incorrect results whereprediction_length>context_length.TODO:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.