Add udev rule to add by-path links for xen vbd devices #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xen vbd (virtual block devices) are the storage devices used on xen instances. On AL1 these devices had by-path symlinks in /dev/disk which were created by a udev rule in 60-persistent-storage.rules, however this rule required that the ID_PATH attribute be set. This attribute isn't set by the systemd version shipped in AL2 (v219) as it's setting for the xen device was removed in v184. Thus add the 51-ec2-xen-vbd-devices.rules udev rule to preserve this behaviour. Note the rule sets the ID_PATH attribute but relies on the existing rule to generate the symlinks. AL1 output: $ ls -l /dev/disk/by-path total 0 lrwxrwxrwx 1 root root 10 May 18 23:45 xen-vbd-51712 -> ../../xvda lrwxrwxrwx 1 root root 11 May 18 23:45 xen-vbd-51712-part1 -> ../../xvda1 AL2 output without patch: $ ls -l /dev/disk/by-path ls: cannot access /dev/disk/by-path: No such file or directory AL2 output with patch: ]$ ls -l /dev/disk/by-path total 0 lrwxrwxrwx 1 root root 10 May 18 23:48 xen-vbd-51712 -> ../../xvda lrwxrwxrwx 1 root root 11 May 18 23:48 xen-vbd-51712-part1 -> ../../xvda1
fred-lefebvre
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xen vbd (virtual block devices) are the storage devices used on xen
instances. On AL1 these devices had by-path symlinks
in /dev/disk which were created by a udev rule in
60-persistent-storage.rules, however this rule required that the
ID_PATH attribute be set. This attribute isn't set by the systemd
version shipped in AL2 (v219) as it's setting for the xen device
was removed in v184. Thus add the 51-ec2-xen-vbd-devices.rules
udev rule to preserve this behaviour. Note the rule sets the ID_PATH
attribute but relies on the existing rule to generate the symlinks.
AL1 output:
$ ls -l /dev/disk/by-path
total 0
lrwxrwxrwx 1 root root 10 May 18 23:45 xen-vbd-51712 -> ../../xvda
lrwxrwxrwx 1 root root 11 May 18 23:45 xen-vbd-51712-part1 -> ../../xvda1
AL2 output without patch:
$ ls -l /dev/disk/by-path
ls: cannot access /dev/disk/by-path: No such file or directory
AL2 output with patch:
]$ ls -l /dev/disk/by-path
total 0
lrwxrwxrwx 1 root root 10 May 18 23:48 xen-vbd-51712 -> ../../xvda
lrwxrwxrwx 1 root root 11 May 18 23:48 xen-vbd-51712-part1 -> ../../xvda1
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.