Add symlink for ENA PTP device. #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
q2ven
force-pushed
the
ena-ptp
branch
2 times, most recently
from
e537442
to
9da6cf0
Compare
ENA PTP device does not have the unique symlink unlike other clock devices: $ sudo rmmod ena && sudo modprobe ena phc_enable=1 $ ls -al /dev/*ptp* crw-------. 1 root root 245, 0 May 29 17:34 /dev/ptp0 $ sudo modprobe ptp_kvm $ ls -al /dev/*ptp* crw-------. 1 root root 245, 0 May 29 17:34 /dev/ptp0 crw-------. 1 root root 245, 1 May 29 17:35 /dev/ptp1 lrwxrwxrwx. 1 root root 4 May 29 17:35 /dev/ptp_kvm -> ptp1 This could lead customers to use a wrong device. Let's add a udev rule to create the unique symlink for ENA PTP as ptp_ena. With the new rule: $ sudo rmmod ena && sudo modprobe ena phc_enable=1 $ ls -al /dev/*ptp* lrwxrwxrwx. 1 root root 4 May 29 17:37 /dev/ptp_ena -> ptp0 crw-------. 1 root root 245, 0 May 29 17:37 /dev/ptp0 crw-------. 1 root root 245, 1 May 29 17:35 /dev/ptp1 lrwxrwxrwx. 1 root root 4 May 29 17:35 /dev/ptp_kvm -> ptp1 Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.