-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): added #45
feat(cli): added #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that creating a new file just for CLI usage is necessary. We can move the subsections from the cli.md
to the usage guide
docs/getting_started/cli.md
Outdated
``` | ||
Usage: amber [OPTIONS] [INPUT] [OUTPUT] | ||
|
||
Arguments: | ||
[INPUT] '-' to read from stdin | ||
[OUTPUT] '-' to output to stdout, '--silent' to discard | ||
|
||
Options: | ||
-e, --eval <EVAL> Code to evaluate | ||
--docs Generate docs (OUTPUT is dir instead, default: `docs/`) | ||
--disable-format Don't format the output file | ||
--minify Minify the resulting code | ||
-h, --help Print help | ||
-V, --version Print version | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This help message will change pretty frequently. I think that we shouldn't include it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was including as reference so people can understand what are the parameters, the man pages usually have this kind of output.
We can update after a release if there are changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can put on top "as per version 0.3.5 this is the help output"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if people will use it and if we will always remember to update this. This is auto generated and I think that standard human behaviour is to use -h
flag when one doesn't know how to use the cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should just tell people to install the cli and use --help
. this will be misleading especially if the user has a different version installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the documentation is for the actual version and not the development release.
at every release the plan is to update the documentation so that section will be updated too, right now I added the version where it was generated.
think that any documentation as this output shown as reference, in this way you don't have to install the tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for now, but it should be worked on later
ref #34