Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Integrate clippy on Rust CI #352

Closed
Mte90 opened this issue Jul 25, 2024 · 4 comments · Fixed by #362
Closed

[Feature] Integrate clippy on Rust CI #352

Mte90 opened this issue Jul 25, 2024 · 4 comments · Fixed by #362
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Mte90
Copy link
Member

Mte90 commented Jul 25, 2024

If someone want to try :-)

@Mte90 Mte90 added enhancement New feature or request good first issue Good for newcomers labels Jul 25, 2024
@b1ek
Copy link
Member

b1ek commented Jul 26, 2024

which linters would you like to add?

@lxl66566
Copy link
Contributor

There's the last clippy issue: module has the same name as its containing module in src/modules/command/mod.rs, and i don't know what's the proper way to rename it.

And then we can add clippy to ci.

@Mte90
Copy link
Member Author

Mte90 commented Jul 26, 2024

which linters would you like to add?

I don't know what it was used for #349 and I think that is the case to use the same.

@Ph0enixKM
Copy link
Member

Ph0enixKM commented Jul 26, 2024

There's the last clippy issue: module has the same name as its containing module in src/modules/command/mod.rs, and i don't know what's the proper way to rename it.

@lxl66566 Let's rename it to cmd.rs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants