ci: require pr's to satisfy clippy requirements #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1ek
changed the title
b1ek
approved these changes
Jul 27, 2024
Mte90
approved these changes
Jul 29, 2024
Mte90
reviewed
Jul 29, 2024
Signed-off-by: lxl66566 <lxl66566@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #352
If this pr merges, every following pr should fix clippy issues to pass ci, which means there will be more restrictions in writing code, sometimes maybe annoying.
clippy can fix some of its issues automatically, running
cargo clippy --fix --allow-dirtyto fix them; But there may still exist some issues that clippy cannot auto-fix.Runs
cargo clippy --all-targets --all-features -- -D warningsto check if there are any unsolved clippy issues.the ci has been tested successfully in this action, cache hitted.
about changes:
./target/depsto./target:./targetcontains./target/deps,./target/debugand more folders to be cached.commandtocmd