Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace '$(echo /bin/bash)' in install commands #105

Merged
merged 1 commit into from
May 26, 2024

Conversation

pmbuko
Copy link
Contributor

@pmbuko pmbuko commented May 24, 2024

Now that the command is no longer using $SHELL on the right side of the pipe, there's no need to over-complicate things.

Now that the command is no longer using `$SHELL` on the right side of the pipe, there's no need to over-complicate things.
@karshPrime
Copy link
Contributor

or you can just do

sh <(curl -s https://raw.githubusercontent.com/Ph0enixKM/AmberNative/master/setup/install.sh)

@b1ek
Copy link
Member

b1ek commented May 25, 2024

or you can just do

sh <(curl -s https://raw.githubusercontent.com/Ph0enixKM/AmberNative/master/setup/install.sh)

sh and bash aren't the same, though. amber compiles to bash, not sh

@karshPrime
Copy link
Contributor

It's for the install script. Reckon that'd work just fine otherwise

$ bash <(curl ...)

Ez

Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reasonable.

Copy link
Member

@b1ek b1ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ph0enixKM Ph0enixKM merged commit cd832b1 into amber-lang:master May 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants