Add test code for stdlib #127
Conversation
you could write code like |
| echo join([\"apple\", \"banana\", \"cherry\"], \", \") | ||
| } | ||
| "; | ||
| test_amber!(code, "apple,banana,cherry") |
There was a problem hiding this comment.
| test_amber!(code, "apple,banana,cherry") | |
| test_amber!(code, "apple, banana, cherry") |
Since we join with the comma and space between - why don't we add the space there as well?
There was a problem hiding this comment.
Even if multiple characters are specified for IFS, it will only be one character when output, so for this case, I'll set it to just ,.
src/tests/stdlib.rs
Outdated
| // TODO: Unable to validate changes in exit code. | ||
| #[test] | ||
| fn exit() { | ||
| let code = " | ||
| import * from \"std\" | ||
| main { | ||
| exit(0) | ||
| } | ||
| "; | ||
| test_amber!(code, "") | ||
| } |
There was a problem hiding this comment.
I think we can leave it like that cuz it's literally running exit command
| @@ -11,6 +11,7 @@ similar-string = "1.4.2" | |||
| colored = "2.0.0" | |||
| itertools = "0.11.0" | |||
| clap = { version = "4.4.18", features = ["derive"] } | |||
| tempfile = "3.10.1" | |||
There was a problem hiding this comment.
This library seems to be well backed. I think it's okay
| @@ -1,7 +1,7 @@ | |||
| pub fun trim(text) { | |||
| return "$\{{nameof text}##*( )}" | |||
| return unsafe $echo "{text}" | xargs$ | |||
There was a problem hiding this comment.
This is not a valid trim function as it basically removes all spaces inside as well.
What's the motivation behind this change in the code?
There was a problem hiding this comment.
I have unified the test_amber macro.
As a result, the test using the trim function in the original test_files/str/trim.ab failed.
Therefore, I copied and pasted the definition of the trim function from src/std/main.ab.
There was a problem hiding this comment.
Oh okay then we have to fix the trim function in a separate issue
|
@b1ek Can you take a look at this? |
src/tests/stdlib.rs
Outdated
|
|
||
| #[test] | ||
| fn file_read() { | ||
| let temp_dir = tempdir().expect("Failed to create temporary directory"); |
src/tests/stdlib.rs
Outdated
|
|
||
| #[test] | ||
| fn file_write() { | ||
| let temp_dir = tempdir().expect("Failed to create temporary directory"); |
src/tests/stdlib.rs
Outdated
|
|
||
| #[test] | ||
| fn file_append() { | ||
| let temp_dir = tempdir().expect("Failed to create temporary directory"); |
|
|
||
| #[test] | ||
| fn file_exist() { | ||
| let temp_dir = tempdir().expect("Failed to create temporary directory"); |
|
@b1ek Thank you for your commit. |
Added test code for std functions.
Unaddressed Items
inputfunction: Couldn't figure out how to write the codetrim_leftfunction: Does not perform as expectedtrim_rightfunction: Does not perform as expectedexitfunction: Unable to validate changes in exit code.I am not familiar with Rust, so please point out any problems.
Closes #117