Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: Fix opt-level in Cargo.toml #155

Merged
merged 1 commit into from
Jun 6, 2024
Merged

hotfix: Fix opt-level in Cargo.toml #155

merged 1 commit into from
Jun 6, 2024

Conversation

b1ek
Copy link
Member

@b1ek b1ek commented Jun 6, 2024

apparently its got to be an integer, not a string

Ph0enixKM
Ph0enixKM approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the build fails with string. Approving and merging without other checks. It's a critical quick fix.

@Ph0enixKM Ph0enixKM merged commit 91fe012 into amber-lang:master Jun 6, 2024
1 check failed
@b1ek b1ek deleted the hotfix-optlevel branch June 6, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ph0enixKM Ph0enixKM Ph0enixKM approved these changes

@boushley boushley Awaiting requested review from boushley

@brumik brumik Awaiting requested review from brumik

@arapower arapower Awaiting requested review from arapower

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@b1ek @Ph0enixKM