feat(std): more commands

[Mte90]

So I added more commands:

• move a wrapper around mv
• change_dir a wrapper around cd but in this way it is generated a cd command fine for shellcheck [Feature] Integration with shellcheck #72
• make_symbolic_link a wrapper around ln -s
• create_dir a wrapper around mkdir -p
• make_executable a wrapper around chmod +x
• switch_user_permission a wrapper around chown -R
• delete a wrapper around rm -fr

In many of those cases there is a check if the file/folder exist, in case return a different boolean value and print the error.
In 2 cases we need the OR condition so we can check if it is file and a folder.

[b1ek]

cd could (and probably should) be added as a bulit in command to amber, like echo

[Ph0enixKM]

@b1ek all the non-failable GNU commands that are parto of POSIX should be built-in.

[b1ek]

@b1ek all the non-failable GNU commands that are parto of POSIX should be built-in.

and most of these

[Ph0enixKM]

Actually... perhaps built-ins could be failable as well:

mv "path/to/file.txt" "other/path/to/file.txt" failed {
    echo "Couldn't move the file"
}

[Mte90]

Let's do a list of commands that need a native support and what needs a function.
Maybe we can support them natively and create functions like I did that improve the usage like a normal scripting language.

[s3than]

This function should have the following changes

pub fun make_executable(path: Text): Null {
    if file_exist(origin) {
        unsafe $chmod +x "{path}"$
        return true
    }

    echo "The file {$path} doesn't exist!"
    return false
}

To

pub fun make_executable(path: Text): Bool {
    if file_exist(path) {
        unsafe $chmod +x "{path}"$
        return true
    }

    echo "The file {path} doesn't exist!"
    return false
}

[Mte90]

So I have to removed the non-failable commands from this PR.

About make_symbolic_link I think that is better to rename it as create_symbolic_link to keep the consistency.

[Mte90]

Probably is missing a function to extract compressed files, download files and to search inside file content.
I will work on those the next days.

[Mte90]

I did some changes and added the download command but I left a note for that.

[b1ek]

every stdlib command should be covered by a test. the tests are in src/tests/stdlib.rs

[Mte90]

every stdlib command should be covered by a test. the tests are in src/tests/stdlib.rs

I never developed with Rust but I guess that is enough to generate the bash and check that is always the same right?
Maybe this can be simplified instead of editing a rust file maybe a pure text file is more simplier?

---

I added also is_root and is_command and improved the download function.

[Ph0enixKM]

@Mte90 if you want to write a standard function to download file, then maybe write one that detects available solution to download it like curl, wget, python and then use the strategy to do it:

if {
    not has_failed("curl") {
        // ... run curl command
    }
    not has_failed("wget") {
        // ... run wget command
    }
    not has_failed("python") {
        // ... run python command (and detect python version)
    }

[Mte90]

not has_failed("wget") {

I think that is better a command that check if exist instead to run it to see what is the error.
In this way we can avoid issues more easily, that is why I added the is_command function.

[Ph0enixKM]

I think that is better a command that check if exist instead to run it to see what is the error. In this way we can avoid issues more easily, that is way I added the is_command function.

Sure! I just wanted to share an example of potential implementation

[Mte90]

So I think that another round of review for the function so I can try to do the unit tests :-)

[b1ek]

There are some conflicts with cargo.lock/toml

ftfy <3

[b1ek]

lgtm

[Mte90]

So I added 3 new commands:

• write that can write or append content
• get_env_var that echo the variable and in case doesn't exist read the variable from the .env file
• load_env_file export a .env file variables

I am fighting with the compilation as we need $(echo "${!var}") to read the variable exported otherwise doesn't work and I am trying to understand how to generate that line in this way.
So right now 2 tests fails.

[Mte90]

So the write function I added is gone as there was already file_write.

[Mte90]

I don't understand the error reported for the get_env_var test https://github.com/Ph0enixKM/Amber/actions/runs/9745193207/job/26892528212?pr=185

Someone that can help my with the Amber code review? @Ph0enixKM

[Ph0enixKM]

ERROR: Failed expression must be followed by a block or statement

This means that the expression you used is failable and you should handle the error @Mte90

[Mte90]

ERROR: Failed expression must be followed by a block or statement

This means that the expression you used is failable and you should handle the error @Mte90

In the meantime I fixed it, also now the CI should have a green check :-)

[Mte90]

This pr is ready :-)

[Ph0enixKM]

Whoa! Didn't expect http_server in the compiler. Does the curl actually download a file?

[Mte90]

it is used only for tests and that part was implemented by @b1ek.

Because initially I did to download a website but the issue was that what is if the user is not connected to internet or the page is not available?

[Ph0enixKM]

Looks good to me