Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: added snap manifest #186

Merged
merged 2 commits into from
Jun 13, 2024
Merged

snap: added snap manifest #186

merged 2 commits into from
Jun 13, 2024

Conversation

soumyaDghosh
Copy link
Contributor

Hi this PR adds the snap package. To register the snap please visit this page. This snap also will need classic as this is a language. For that will need an application in the forum. You can add me as a collaborator after registering the snap name, so that I can handle the rest!

Copy link
Member

@b1ek b1ek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ph0enixKM
Copy link
Member

Ph0enixKM commented Jun 13, 2024

I've signed the name for amber-bash. Will we have to update the version in Cargo.toml and snapcraft.yaml as well? We could write a simple amber script to do it quickly. Perhaps not in the scope of this issue but overall.

Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Ph0enixKM Ph0enixKM merged commit 9ff58d4 into amber-lang:master Jun 13, 2024
1 check passed
@Ph0enixKM
Copy link
Member

@soumyaDghosh I'll keep you updated when they approve the name. You can message me on Discord or via email to keep in touch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants