fix: add musl support #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Ph0enixKM
commented
Jun 13, 2024
Comment on lines
-16
to
-25
| let target_str = "" | ||
| loop target in targets { | ||
| target_str += "--target {target} " | ||
| } | ||
| $cargo build --release {target_str}$ | ||
| // Move ambers to the release directory | ||
| $mv target/aarch64-apple-darwin/release/amber target/release/amber_macos_aarch64$ | ||
| $mv target/aarch64-unknown-linux-musl/release/amber target/release/amber_linux_aarch64$ | ||
| $mv target/x86_64-apple-darwin/release/amber target/release/amber_macos_x86_64$ | ||
| $mv target/x86_64-unknown-linux-musl/release/amber target/release/amber_linux_x86_64$ |
There was a problem hiding this comment.
I used to use this script to recompile binaries. Now they are compiled in the cloud hence the code deletion. This script only recompiles the installer and uninstaller scripts now.
arapower
approved these changes
Jun 14, 2024
b1ek
reviewed
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also bumps version to 0.3.3-alpha to patch the musl support installer