feat(installer): added prompt for telemetry

[Mte90]

Fix #254

I didn't tested it yet.

[b1ek]

what about not having telemetry at all? that seems like something really out of place in a FOSS project, especially with data not being publicly available

[Mte90]

In this case it is used only to gather the installation number and the system.
I think that this data should be available publicly.
Anyway github already as a download counter for the assets but is not very known.

https://tooomm.github.io/github-release-stats/?username=Ph0enixkm&repository=Amber

So maybe yes we can remove it but I think that is something that @Ph0enixKM has to explain.

[Ph0enixKM]

I used this to gather the statistics for the thesis project. I'll make it publicly available in a separate task. Can we at least preserve the counter without sending the data about the OS? I think that people will rather select "no" 95% of the time

[Mte90]

I think that we can kept it that but we need to show publicly those numbers.
For sake of transparency and add a link to the installer of the page that shows the numbers.

[Ph0enixKM]

@Mte90 I’ll build that page in my free time and add the link to it in the installer source code

[b1ek]

I think that people will rather select "no" 95% of the time

yeah, because the user doesn't care about that sort of thing. and they shouldn't. its not their responsibility

it is our responsibility to give the user a nice experience, though

[Mte90]

I think that in the meantime the page get created we can just have this prompt.

I don't like the idea to wait for the new page in the meantime and still have this telemetry opt-out

[b1ek]

just remove the telemetry, completely

it doesn't have a place in a FOSS project. at all. no user will benefit from a download count, or OS stats

[Mte90]

@Ph0enixKM if we can decide I want to rewrite the installer with the latest stdlib new functions.

[Ph0enixKM]

I understand that you don't like telemetry embedded in the projects. The telemetry got it's way there to show people that Amber is not just a side project that nobody is using. I already created a presentation with the popularity metrics and how well the project is doing. Removing the telemetry will ruin the data that I'm aggregating for the presentation that will happen this fall.

What is being aggregated?

User's IP to just uniquely identify the user and uname to guess what OS is used by the user.

Proposition

I propose to simply build a subpage for the amber-lang.com to enable people to view the telemetry data. Furthermore let's ask user in the installer script if they want to help us develop the project by sending the information about the OS they're using. If so, let's ask them to provide their nickname. If the nickname is a github nickname we will display the nickname as a link to the github account in the website displaying the data of the database.

This particular feature could encourage users to contribute to the project and have a sense of association.

The prompt:

> Would you like to help improve Amber by sharing your OS info with our developer database? Enter your GitHub nickname (or any nickname) or type `no`:

Conclusion

@Mte90 the installer script can be rewritten as is for now. The PR should be opened for the https://github.com/amber-lang/amber-website as well. This is a bigger issue. I will write the website part hopefully today.

[Mte90]

Changed the text in the prompt but the nickname is not shared yet

[Ph0enixKM]

@Mte90 I'll build the appropriate endpoint and add the nickname prop to it so that you can share it.

The website should be ready by tomorrow.

[Ph0enixKM]

I had to merge this ASAP otherwise the website wouldn't work with newly formatted data amber-lang/amber-website#2

[Mte90]

We need a maintainer to approve it...

[Ph0enixKM]

We have to update the installer now

[Ph0enixKM]

We need a maintainer to approve it...

I was talking about the website code

[Ph0enixKM]

@Mte90 can you also recompile this script?

done

[Ph0enixKM]

LGTM