Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show doc path after generated it #338

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Show doc path after generated it #338

merged 7 commits into from
Jul 26, 2024

Conversation

Mte90
Copy link
Member

@Mte90 Mte90 commented Jul 23, 2024

Ref: #337

Now shows the path when the documentation is generated.

@Mte90 Mte90 requested a review from Ph0enixKM July 23, 2024 11:21
@Mte90 Mte90 mentioned this pull request Jul 23, 2024
Closed
Mte90
Mte90 commented Jul 23, 2024
View reviewed changes
src/compiler.rs Outdated Show resolved Hide resolved
@Ph0enixKM

This comment was marked as duplicate.

Sign in to view
Ph0enixKM
Ph0enixKM approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This can be improved:

  1. Let's generate one info with all the paths instead of generating a lot of separate infos
  2. Let's fix the path so that no // happen in the path

Ph0enixKM
Ph0enixKM requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mte90 Here are some instructions on how to address the concerns

src/main.rs Outdated Show resolved Hide resolved
src/compiler.rs Outdated Show resolved Hide resolved
Mte90 and others added 2 commits July 26, 2024 11:04
@Mte90 @Ph0enixKM
Update src/compiler.rs
23faaf0 
Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>
@Mte90
feat(review): doc
e3c7fab
@Mte90 Mte90 requested a review from Ph0enixKM July 26, 2024 12:13
Ph0enixKM
Ph0enixKM requested changes Jul 26, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the help message?

src/main.rs Outdated Show resolved Hide resolved
@Mte90 @Ph0enixKM
Update src/main.rs
aa2ad5f 
Co-authored-by: Phoenix Himself <pkaras.it@gmail.com>
@Mte90 Mte90 requested a review from Ph0enixKM July 26, 2024 13:35
Ph0enixKM
Ph0enixKM approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@Ph0enixKM Ph0enixKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Ph0enixKM Ph0enixKM merged commit 10293fb into amber-lang:master Jul 26, 2024
1 check passed
@Mte90 Mte90 deleted the doc-cli branch September 5, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CymDeveloppement CymDeveloppement CymDeveloppement approved these changes

@Ph0enixKM Ph0enixKM Ph0enixKM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mte90 @Ph0enixKM @CymDeveloppement